Skip to content

Fix runnning arm unittests on FVP #7178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix runnning arm unittests on FVP #7178

merged 2 commits into from
Dec 6, 2024

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Dec 4, 2024

  • Adds _test_options to pytest namespace which has a proper global scope
  • Removes test option enum which is not compatible with new approach
  • Adds back expectedFailures which passed due to not running on FVP

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7178

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ede3388 with merge base 63238ab (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 4, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@AdrianLundell
Copy link
Collaborator Author

AdrianLundell commented Dec 5, 2024 •
edited
Loading

All reported failures are
ERROR: Could not install packages due to an OSError
-> not related to patch

@AdrianLundell
Fix runnning arm unittests on FVP
a18a85c 
- Adds _test_options to pytest namespace which has a proper global scope
- Removes test option enum which is not compatible with new approach
- Adds back expectFailureOnFVPs which passed due to not running on FVP

Change-Id: I0ecea1360e1193e0f7cbff01d54dc005ef481005
@AdrianLundell AdrianLundell merged commit 98e4dd5 into pytorch:main Dec 6, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddan80 freddan80 freddan80 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdrianLundell @freddan80 @facebook-github-bot